[PATCH 1/2] board: tbs2910: Use recommended distroboot addresses

[Stefano Babic]

Hi Soeren,

On 02.10.20 12:40, Soeren Moch wrote:
> Stefano, Tom,
> 
> I would really like to see this merged for v2020.10. Maybe there are no
> other imx patches pending for v2020.10,

Right, I do not see urgent fixes, and remaining patches will be merged
after release.

> so maybe Tom can pick up this
> directly (as the original patch for sysboot support, that was merged in
> -next for v2020.10-rc1)?

Fine with me - @Tom, could you pick up this ?

> 
> This really is a fix for this newly added sysboot support on tbs2910, so
> it would be great to get the properly fixed addresses and dtb
> declaration into the final release. The u-boot internal device tree must
> not be used for booting linux, since this dtb is stripped down. And the
> recommended kernel address avoids the additional self-relocation of the
> kernel after starting linux.

Regards,
Stefano

> 
> Thanks,
> Soeren
> 
> On 27.08.20 21:52, Soeren Moch wrote:
>> According to doc/README.distro fdt_addr must not be set when DTB is not
>> available from hardware. So remove this entry.
>>
>> Use address 32MB above the start of DRAM for kernel_addr_r. This way
>> we likely can avoid the self-relocation of the compressed kernel image
>> before it decompresses to offset 0x8000 from start of DRAM.
>>
>> Use address 128MB above the start of DRAM for fdt_addr_r, since this is
>> the maximum location for the end of the kernel. So we avoid overwriting
>> the DTB.
>>
>> Use 512k above that for ramdisk_addr_r. This should be enough for the
>> DTB, rest of DRAM can be used for initrd.
>>
>> Place boot script / extlinux.conf at offset 0 / 1MB from start of DRAM.
>> This space is available for processing in U-Boot.
>>
>> Signed-off-by: Soeren Moch <smoch at web.de>
>> ---
>> Cc: Stefano Babic <sbabic at denx.de>
>> Cc: Fabio Estevam <festevam at gmail.com>
>> Cc: Denis 'GNUtoo' Carikli <GNUtoo at cyberdimension.org>
>> Cc: u-boot at lists.denx.de
>>
>> Recommendations taken from [1].
>>
>> Distroboot support for the tbs2910 board was added in the v2020.10
>> merge window. So please pull this in as fix for v2020.10.
>>
>> Thanks,
>> Soeren
>>
>> [1] https://lists.denx.de/pipermail/u-boot/2020-January/398482.html
>> ---
>>  include/configs/tbs2910.h | 11 +++++------
>>  1 file changed, 5 insertions(+), 6 deletions(-)
>>
>> diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h
>> index 8092b9edfb..b05034945e 100644
>> --- a/include/configs/tbs2910.h
>> +++ b/include/configs/tbs2910.h
>> @@ -85,13 +85,12 @@
>>  			"bootm 0x10800000 0x10d00000\0" \
>>  	"console=ttymxc0\0" \
>>  	"fan=gpio set 92\0" \
>> -	"fdt_addr=0x13000000\0" \
>> -	"fdt_addr_r=0x13000000\0" \
>> +	"fdt_addr_r=0x18000000\0" \
>>  	"fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \
>> -	"kernel_addr_r=0x10008000\0" \
>> -	"pxefile_addr_r=0x10008000\0" \
>> -	"ramdisk_addr_r=0x18000000\0" \
>> -	"scriptaddr=0x14000000\0" \
>> +	"kernel_addr_r=0x12000000\0" \
>> +	"pxefile_addr_r=0x10100000\0" \
>> +	"ramdisk_addr_r=0x18080000\0" \
>> +	"scriptaddr=0x10000000\0" \
>>  	"set_con_serial=setenv stdout serial; " \
>>  			"setenv stderr serial\0" \
>>  	"set_con_hdmi=setenv stdout serial,vidconsole; " \
>> --
>> 2.17.1
>>


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================