[PATCH v4 1/2] arm: rmobile: Add PRR CPU ID macros for RZ/G2[HMNE]

Marek Vasut marek.vasut at gmail.com
Sat Oct 3 21:04:59 CEST 2020


On 10/1/20 12:36 PM, Biju Das wrote:
[...]

> diff --git a/arch/arm/mach-rmobile/include/mach/rmobile.h b/arch/arm/mach-rmobile/include/mach/rmobile.h
> index a50249dc96..bd4bd01b75 100644
> --- a/arch/arm/mach-rmobile/include/mach/rmobile.h
> +++ b/arch/arm/mach-rmobile/include/mach/rmobile.h
> @@ -27,6 +27,10 @@
>  /* PRR CPU IDs */
>  #define RMOBILE_CPU_TYPE_SH73A0		0x37
>  #define RMOBILE_CPU_TYPE_R8A7740	0x40
> +#define RMOBILE_CPU_TYPE_R8A774A1	0x52

The problem here is that this is the same as
#define RMOBILE_CPU_TYPE_R8A7796   0x52

So if you use that ^ in the code, you cannot discern it from
RMOBILE_CPU_TYPE_R8A774A1 .

We really need to find a way to tell these two apart first, e.g. by
checking the bootrom, and then use it in U-Boot all over the place.


More information about the U-Boot mailing list