[PATCH v2 1/1] log: mute messages generated by log drivers

Simon Glass sjg at chromium.org
Mon Oct 5 12:56:35 CEST 2020


Hi Heinrich,

On Mon, 5 Oct 2020 at 04:42, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> On 05.10.20 12:21, Heinrich Schuchardt wrote:
> > When a message is written by a log driver (e.g. via the network stack) this
> > may result in the generation of further messages. We cannot allow these
> > additional messages to be emitted as this might result in an infinite
> > recursion.
> >
> > Up to now only the syslog driver was safeguarded. We should safeguard all
> > log drivers instead.
> >
> > Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> > ---
> > This patch is based on
> >
> > [PATCH v3 0/3] doc: global data pointer
> > https://lists.denx.de/pipermail/u-boot/2020-October/428475.html
> >
> > v2:
> >       move processing_msg to global data pointer
> >       (Simon reported a problem with SPL log messages when useing a
> >       static variable)
>
> Hello Simon,
>
> this is what is needed based on origin/master.
>
> In origin/next the first version of the patch was merged.
>
> What should I use as basis?

I think you need to use -next since that is where we are now. Also,
could you add a log_ prefix to your global_data var and perhaps make
it a bool?

Regards,
Simon


More information about the U-Boot mailing list