[PATCH 02/18] log: Fix incorrect documentation of log_filter.cat_list

Heinrich Schuchardt xypron.glpk at gmx.de
Tue Oct 6 22:41:17 CEST 2020


On 10/6/20 9:15 PM, Sean Anderson wrote:
> This list is expected to be terminated by LOGC_END, not LOGC_NONE.

%s/This list is expected to be/Logging category lists are/

>
> Fixes: e9c8d49d54 ("log: Add an implementation of logging")
>
> Signed-off-by: Sean Anderson <seanga2 at gmail.com>
> ---
>
>  include/log.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/log.h b/include/log.h
> index 2859ce1f2e..670b9a665d 100644
> --- a/include/log.h
> +++ b/include/log.h
> @@ -349,7 +349,7 @@ enum log_filter_flags {
>   *	new filter, and must be provided when removing a previously added
>   *	filter.
>   * @flags: Flags for this filter (LOGFF_...)
> - * @cat_list: List of categories to allow (terminated by LOGC_none). If empty
> + * @cat_list: List of categories to allow (terminated by LOGC_END). If empty
>   *	then all categories are permitted. Up to LOGF_MAX_CATEGORIES entries
>   *	can be provided
>   * @max_level: Maximum log level to allow
>

This matches function log_has_cat().

Except for the commit message:

Reviewed-by: Heinrich Schuchardt <xypron.glpk at gmx.de>


More information about the U-Boot mailing list