[PATCH 0/5] configs: ti: am65x/j721e: Use DEFAULT_LINUX_BOOT_ENV

Nishanth Menon nm at ti.com
Wed Oct 7 14:11:43 CEST 2020


On 11:15-20201007, Lokesh Vutla wrote:
> 
> 
> On 07/10/20 12:35 am, Nishanth Menon wrote:
> > Use the common defaults from ./include/configs/ti_armv7_common.h
> > 
> > This saves us from rediscovering the same painful lessons learnt from
> > ARMv7 (kernel dtbs ramdisks overlays stomping on each other etc..)
> 
> If PATCH 3 is made as PATCH 1, then existing PATCH (1&4) and  PATCH (2&5) can be
> combined.


Does'nt that break bisectability?
include/environment/ti/ufs.h defines DEFAULT_UFS_TI_ARGS using
overlayaddr, include/configs/j721e_evm.h uses that macro in
CONFIG_EXTRA_ENV_SETTINGS, if I move patch 3 as patch 1, dtboaddr is not
defined since DEFAULT_LINUX_BOOT_ENV is not yet included..

I know that am654 probably does'nt use DEFAULT_UFS_TI_ARGS, but it
looked elegant to clean it up in stages together.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


More information about the U-Boot mailing list