[fs/squashfs PATCH v3 1/2] Add warning for dynamic memory usage.
Miquel Raynal
miquel.raynal at bootlin.com
Thu Oct 8 09:28:03 CEST 2020
Hi Mauro,
Mauro Condarelli <mc5686 at mclink.it> wrote on Thu, 8 Oct 2020 00:30:20
+0200:
> SquashFS may need a large amount of dynamic memory fot its buffers,
> especially if and when compression is enabled I got failures with
> CONFIG_SYS_MALLOC_LEN < 0x4000.
>
> I found no way to enforce this in Kconfig itself, so I resorted
> to ada a warning in help string.
Nit: s/ada/add/ s/in help/in the help/?
Besides that,
Reviewed-by: Miquel Raynal <miquel.raynal at bootlin.com>
>
> Signed-off-by: Mauro Condarelli <mc5686 at mclink.it>
> ---
>
> (no changes since v1)
>
> fs/squashfs/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/squashfs/Kconfig b/fs/squashfs/Kconfig
> index 54ab1618f1..7c3f83d007 100644
> --- a/fs/squashfs/Kconfig
> +++ b/fs/squashfs/Kconfig
> @@ -9,3 +9,5 @@ config FS_SQUASHFS
> filesystem use, for archival use (i.e. in cases where a .tar.gz file
> may be used), and in constrained block device/memory systems (e.g.
> embedded systems) where low overhead is needed.
> + WARNING: if compression is enabled SquashFS needs a large amount
> + of dynamic memory; make sure CONFIG_SYS_MALLOC_LEN >= 0x4000.
Thanks,
Miquèl
More information about the U-Boot
mailing list