[PATCH 2/3] net: Expose some errors generated in net_init

Tom Rini trini at konsulko.com
Mon Oct 12 03:15:12 CEST 2020


On Sat, Sep 12, 2020 at 05:45:43PM -0400, Sean Anderson wrote:

> net_init does not always succeed, and there is no existing mechanism to
> discover errors. This patch allows callers of net_init (such as net_init)
> to handle errors. The root issue is that eth_get_dev can fail, but
> net_init_loop doesn't expose that. The ideal way to fix eth_get_dev would
> be to return an error with ERR_PTR, but there are a lot of callers, and all
> of them just check if it's NULL. Another approach would be to change the
> signature to something like
> 
> int eth_get_dev(struct udevice **pdev)
> 
> but that would require rewriting all of the many callers.
> 
> Signed-off-by: Sean Anderson <seanga2 at gmail.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201011/6edd7af7/attachment.sig>


More information about the U-Boot mailing list