[PATCH 3/8] phy: nop-phy: add optional clk

Peng Fan peng.fan at nxp.com
Mon Oct 12 11:12:55 CEST 2020


> Subject: Re: [PATCH 3/8] phy: nop-phy: add optional clk
> 
> On 10/12/20 8:23 AM, Peng Fan wrote:
> [...]
> > +static int nop_phy_probe(struct udevice *dev) {
> > +	struct nop_phy_priv *priv = dev_get_priv(dev);
> > +	int ret;
> > +
> > +	if (CONFIG_IS_ENABLED(CLK)) {
> > +		ret = clk_get_by_name(dev, "main_clk", &priv->nop_clk);
> 
> So is this main_clk or nop_clk ?
> 
> Wouldn't it be better if the NOP PHY used the clk_bulk and enabled all clock
> described in DT ?

Bulk seems better.

Thanks,
Peng.


More information about the U-Boot mailing list