[PATCH] SPL: stm32mp1: fix spl_mmc_boot_partition not defined

Richard Genoud richard.genoud at posteo.net
Tue Oct 13 14:25:09 CEST 2020


Hi Patrick,

Le 13/10/2020 à 14:18, Patrick DELAUNAY a écrit :
> Hi Richard,
> 
>> From: Richard Genoud <richard.genoud at posteo.net>
>> Sent: lundi 12 octobre 2020 16:11
>>
>> spl_mmc_boot_partition is only defined when
>> CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION is defined.
>>
>> Signed-off-by: Richard Genoud <richard.genoud at posteo.net>
>> ---
>>   arch/arm/mach-stm32mp/spl.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
> 
> Reviewed-by: Patrick Delaunay <patrick.delaunay at st.com>
> 
> Thanks for this missing check in spl.
> 
> NB: after check, it is possible to IS_ENABLED to prevent #ifdef here
> 
> <unknown>:0: warning: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible

I don't think it's possible to use "if (IS_ENABLED(CONFIG...))"
since we have to remove the whole function, not just some code in it.

Regards,
Richard


More information about the U-Boot mailing list