[PATCH v2 05/22] log: Use CONFIG_IS_ENABLED() for LOG_TEST

Simon Glass sjg at chromium.org
Wed Oct 14 15:07:33 CEST 2020


Hi Sean,

On Mon, 12 Oct 2020 at 10:56, Sean Anderson <seanga2 at gmail.com> wrote:
>
> On 10/11/20 11:35 PM, Simon Glass wrote:
> > On Sat, 10 Oct 2020 at 13:43, Sean Anderson <seanga2 at gmail.com> wrote:
> >>
> >> Checkpatch complains about using #ifdef for CONFIG variables.
> >>
> >> Signed-off-by: Sean Anderson <seanga2 at gmail.com>
> >> ---
> >>
> >> (no changes since v1)
> >>
> >>  cmd/log.c           | 4 ++--
> >>  test/log/log_test.c | 2 +-
> >>  2 files changed, 3 insertions(+), 3 deletions(-)
> >>
> >
> > You can ignore this warning.
> >
>
> Perhaps it should be downgraded to a check instead of a warning?
>

That sounds like a good idea. There are quite a few places where #if
is needed, despite this useful exhortation.

Regards,
Simon


More information about the U-Boot mailing list