[PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

Alper Nebi Yasak alpernebiyasak at gmail.com
Wed Oct 14 20:58:28 CEST 2020


On 14/10/2020 18:24, Tom Rini wrote:
> On Tue, Oct 13, 2020 at 09:54:55AM -0600, Simon Glass wrote:
>> I think it is OK to change the file to GPL2. I'm not sure if changing
>> coreboot parts to 2.0+ is an option. I believe the use of 2+ in U-Boot
>> is for fairly narrow reasons, but I'm not sure if that is documented
>> anywhere.
>>
>> +Tom Rini might have a comment
> 
> Ugh.  In so far as anything can be re-licensed, who did it all
> originally?  I suspect coreboot isn't interested in 2.0+ but we can do
> 2.0-only.

For this patch, coreboot commit b9a7877568cf ("rockchip/*: refactor edp
driver") introduces the related change to src/soc/rockchip/common/edp.c
renamed from .../rk3288/edp.c, which was introduced at coreboot commit
40f558e8f4f7 ("rockchip: support display").

    $ git shortlog -s -e b9a7877568cf -- src/soc/rockchip/{common,rk3288}/edp.c
    >     2  Julius Werner <jwerner at chromium.org>
    >     1  Lin Huang <hl at rock-chips.com>
    >     1  Patrick Georgi <pgeorgi at chromium.org>
    >     1  Patrick Georgi <pgeorgi at google.com>
    >     4  huang lin <hl at rock-chips.com>

The sign-offs are:

    $ git log b9a7877568cf -- src/soc/rockchip/{common,rk3288}/edp.c \
        | grep -i "Signed-off-by:" | sort -u
    >    Original-Signed-off-by: huang lin <hl at rock-chips.com>
    >    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    >    Original-Signed-off-by: Lin Huang <hl at rock-chips.com>
    >    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    >    Signed-off-by: Stefan Reinauer <reinauer at chromium.org>

That file at that refactor-commit has two more fixes I'm interested in,
and it's not the only file things could be ported from. If I run the
above on a wider list of files upto current master I get 16 authors or
20 signoffs with duplicates (including e.g. original-signed-off-by),
most of them either @google.com, @chromium.org, or @rock-chips.com.

    $ git shortlog -s -e -- src/soc/rockchip/{common,rk3288,rk3399}/{include/soc/,include/,}{edp,vop,display,mipi}{.c,.h}
    >     1  Angel Pons <th3fanbus at gmail.com>
    >     1  Arthur Heymans <arthur at aheymans.xyz>
    >     3  David Hendricks <dhendrix at chromium.org>
    >     1  Ege Mihmanli <egemih at google.com>
    >    15  Elyes HAOUAS <ehaouas at noos.fr>
    >     1  Jacob Garber <jgarber1 at ualberta.ca>
    >     7  Julius Werner <jwerner at chromium.org>
    >     1  Kyösti Mälkki <kyosti.malkki at gmail.com>
    >    13  Lin Huang <hl at rock-chips.com>
    >     1  Martin Roth <martinroth at google.com>
    >     2  Nickey Yang <nickey.yang at rock-chips.com>
    >     1  Patrick Georgi <pgeorgi at chromium.org>
    >     3  Patrick Georgi <pgeorgi at google.com>
    >     2  Shunqian Zheng <zhengsq at rock-chips.com>
    >     2  Yakir Yang <ykk at rock-chips.com>
    >     5  huang lin <hl at rock-chips.com>

    $ git log -- src/soc/rockchip/{common,rk3288,rk3399}/{include/soc/,include/,}{edp,vop,display,mipi}{.c,.h} \
        | grep -i "Signed-off-by:" | sort -u
    >    Original-Signed-off-by: David Hendricks <dhendrix at chromium.org>
    >    Original-Signed-off-by: huang lin <hl at rock-chips.com>
    >    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    >    Original-Signed-off-by: Lin Huang <hl at rock-chips.com>
    >    Original-Signed-off-by: Shunqian Zheng <zhengsq at rock-chips.com>
    >    Original-Signed-off-by: Yakir Yang <ykk at rock-chips.com>
    >    Signed-off-by: Angel Pons <th3fanbus at gmail.com>
    >    Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
    >    Signed-off-by: Ege Mihmanli <egemih at google.com>
    >    Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
    >    Signed-off-by: Jacob Garber <jgarber1 at ualberta.ca>
    >    Signed-off-by: Julius Werner <jwerner at chromium.org>
    >    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
    >    Signed-off-by: Lin Huang <hl at rock-chips.com>
    >    Signed-off-by: Martin Roth <martinroth at google.com>
    >    Signed-off-by: Nickey Yang <nickey.yang at rock-chips.com>
    >    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
    >    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    >    Signed-off-by: Patrick Georgi <pgeorgi at google.com>
    >    Signed-off-by: Stefan Reinauer <reinauer at chromium.org>

(There's also hdmi{.c,.h} licensed w/ GPL-2.0-or-later, and clock{.c,.h}
for which the U-Boot counterpart is already "GPL-2.0" assuming thats
GPL-2.0-only, so I've excluded both.)


More information about the U-Boot mailing list