[PATCH v3 2/2] spl: fdt: Record load/entry fit-images entries in 64bit format

Michal Simek michal.simek at xilinx.com
Thu Oct 15 18:18:28 CEST 2020



On 15. 10. 20 17:05, Simon Glass wrote:
> On Mon, 12 Oct 2020 at 01:51, Michal Simek <michal.simek at xilinx.com> wrote:
>>
>> The commit 9f45aeb93727 ("spl: fit: implement fdt_record_loadable") which
>> introduced fdt_record_loadable() state there spl_fit.c is not 64bit safe.
>> Based on my tests on Xilinx ZynqMP zcu102 platform there shouldn't be a
>> problem to record these addresses in 64bit format.
>> The patch adds support for systems which need to load images above 4GB.
>>
>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
>> ---
>>
>> (no changes since v1)
>>
>>  common/fdt_support.c | 9 ++-------
>>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> I am wondering whether we should use #size-cells etc. to select this?
> 

size-cells/address-cells are used for reg property. We are not using it
and it is really just property with two cells which are pointing to
address. That's why I don't think we need this property there.

Thanks,
Michal


More information about the U-Boot mailing list