[PATCH v2 0/5] mtd: pxa3xx_nand: add support for Armada 8k

[Stefan Roese]

Hi Baruch,
Hi Chris,

On 19.10.20 07:24, Baruch Siach wrote:
> Hi Chris,
> 
> On Sun, Oct 18 2020, Chris Packham wrote:
>> On Mon, Oct 19, 2020 at 1:59 AM Baruch Siach <baruch at tkos.co.il> wrote:
>>>
>>> This series adds NAND flash support to Aramda 8k systems. Patches make the
>>> necessary changes to the pxa3xx_nand driver and DT files.
>>>
>>> v2:
>>>    Rebase on current master. Fixes conflict with commit 661c98121d4 ("mtd: nand:
>>>    pxa3xx: Fix not calling dev_xxx with a device")
>>
>> Is it worth looking at bringing in the newer marvell_nand driver from
>> Linux? I suspect that it will be easier to keep in sync with changes
>> for the Armada 8K. I have considered it in the past but it kind of
>> fell off my radar.
> 
> The kernel raw nand API has seen some significant changes recently. It
> looks like the kernel marvell_nand driver relies on newer API. I'm not
> sure how easy would be syncing the drivers to a degree that makes
> porting of changes trivial. It would probably require many other changes
> in generic U-Boot raw NAND code.

I agree that without a re-sync with a more recent Linux MTD (NAND) core
code, this task might prove complex and failure prone. And sync'ing the
MTD core is also a pretty complex task which needs to be done very
carefully, to not break any existing platforms. FWICT, nobody is working
on it right now and we can't wait for this to happen and stall the
development here. So from my point of view, I'm okay with updates to
the current PXA NAND driver. Testing of these patches on other platforms
would be very welcome though.

> Maybe Miquel can shed some light on that.
> 
> Unfortunately, the U-Boot MAINTAINERS NAND FLASH entry is marked
> "Orphaned (Since 2018-07)".

Yes, this is unfortunate. Volunteers are always welcome. ;)

Thanks,
Stefan

> baruch
> 
>>> Baruch Siach (2):
>>>    arm: dts: armada-cp110-master: update nand-controller
>>>    mtd: pxa3xx_nand: remove dead code
>>>
>>> Shmuel Hazan (3):
>>>    arm: dts: armada-cp110-slave: add missing cps_nand
>>>    mtd: pxa3xx_nand: port to use driver model
>>>    mtd: nand: pxa3xx: enable NAND controller if the SoC needs it
>>>
>>>   arch/arm/dts/armada-cp110-master.dtsi |  15 ++-
>>>   arch/arm/dts/armada-cp110-slave.dtsi  |  16 +++
>>>   drivers/mtd/nand/raw/Kconfig          |   2 +
>>>   drivers/mtd/nand/raw/pxa3xx_nand.c    | 179 ++++++++++++++------------
>>>   4 files changed, 124 insertions(+), 88 deletions(-)
>>>
>>> --
>>> 2.28.0
>>>
> 
> 


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de