[PATCH v4 23/27] video: omap: drop domain clock enabling by SOC api

[Dario Binacchi]

Hi Lokesh,

> Il 20/10/2020 08:31 Lokesh Vutla <lokeshvutla at ti.com> ha scritto:
> 
>  
> On 19/10/20 10:22 pm, Dario Binacchi wrote:
> > Enabling the domain clock is performed by the sysc interconnect target
> > module driver during the video device probing.
> > 
> > Signed-off-by: Dario Binacchi <dariobin at libero.it>
> > 
> > ---
> > 
> > (no changes since v3)
> > 
> > Changes in v3:
> > - Remove clock domain enabling/disabling.
> > - Update the commit message.
> > 
> >  arch/arm/mach-omap2/am33xx/clock_am33xx.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/mach-omap2/am33xx/clock_am33xx.c b/arch/arm/mach-omap2/am33xx/clock_am33xx.c
> > index 2427933c8b..cf71192360 100644
> > --- a/arch/arm/mach-omap2/am33xx/clock_am33xx.c
> > +++ b/arch/arm/mach-omap2/am33xx/clock_am33xx.c
> > @@ -226,7 +226,7 @@ void enable_basic_clocks(void)
> >  		&cmper->usb0clkctrl,
> >  		&cmper->emiffwclkctrl,
> >  		&cmper->emifclkctrl,
> > -#if CONFIG_IS_ENABLED(AM335X_LCD)
> > +#if CONFIG_IS_ENABLED(AM335X_LCD) && !CONFIG_IS_ENABLED(DM_VIDEO)
> >  		&cmper->lcdclkctrl,
> >  		&cmper->lcdcclkstctrl,
> 
> Now that we are enabling clocks from DT, can we drop this hunk all together?

Yes. Actually, the device tree only references the lcdclkctrl register (<&lcdc_clkctrl AM3_LCDC_LCDC_CLKCTRL 0>;) The lcdcclkstctrl register is not referenced by any device tree node. It is also not found in the include/dt-bindings/clock/am3.h file. Nevertheless, the display works.

Regards,
Dario
> 
> Thanks and regards,
> Lokesh
> 
> >  #endif
> >