[PATCH v5 2/9] binman: Only write FDT once per node
Samuel Holland
samuel at sholland.org
Thu Oct 22 04:12:09 CEST 2020
Due to an extra level of indentation, the "data" property containing the
FDT was being written repeatedly after every other property in the node.
This caused the generated FIT image to be invalid.
Move the block up one level, so the property is added exactly once.
Reviewed-by: Simon Glass <sjg at chromium.org>
Signed-off-by: Samuel Holland <samuel at sholland.org>
---
tools/binman/etype/fit.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/binman/etype/fit.py b/tools/binman/etype/fit.py
index de4745c5521..8a24f12aa59 100644
--- a/tools/binman/etype/fit.py
+++ b/tools/binman/etype/fit.py
@@ -205,10 +205,10 @@ class Entry_fit(Entry):
b'SEQ', tools.ToBytes(str(seq + 1)))
fsw.property(pname, val)
- # Add data for 'fdt' nodes (but not 'config')
- if depth == 1 and in_images:
- fsw.property('data',
- tools.ReadFile(fname))
+ # Add data for 'fdt' nodes (but not 'config')
+ if depth == 1 and in_images:
+ fsw.property('data',
+ tools.ReadFile(fname))
else:
if self._fdts is None:
if self._fit_list_prop:
--
2.26.2
More information about the U-Boot
mailing list