[PATCH v2 17/30] acpi: Correct reset handling in acpi_device_add_power_res()

Simon Glass sjg at chromium.org
Thu Oct 22 05:02:50 CEST 2020


If there is no reset line, this still emits ACPI code for the reset GPIO.
Fix it by updating the check.

Signed-off-by: Simon Glass <sjg at chromium.org>
Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
---

(no changes since v1)

 lib/acpi/acpi_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/acpi/acpi_device.c b/lib/acpi/acpi_device.c
index 95dfac583fc..c3439a59883 100644
--- a/lib/acpi/acpi_device.c
+++ b/lib/acpi/acpi_device.c
@@ -422,7 +422,7 @@ int acpi_device_add_power_res(struct acpi_ctx *ctx, u32 tx_state_val,
 
 	/* Method (_ON, 0, Serialized) */
 	acpigen_write_method_serialized(ctx, "_ON", 0);
-	if (reset_gpio) {
+	if (has_reset) {
 		ret = acpigen_set_enable_tx_gpio(ctx, tx_state_val, dw0_read,
 						 dw0_write, &reset, true);
 		if (ret)
-- 
2.29.0.rc1.297.gfa9743e501-goog



More information about the U-Boot mailing list