[PATCH] ARM: dts: stm32: Reinstate card detect behavior on DHSOM
Marek Vasut
marex at denx.de
Thu Oct 22 20:18:56 CEST 2020
On 10/22/20 7:17 PM, Patrick DELAUNAY wrote:
> Hi Marek,
Hi,
>> From: Marek Vasut <marex at denx.de>
>> Sent: lundi 19 octobre 2020 23:38
>>
>> The cd-gpios with (GPIO_ACTIVE_LOW | GPIO_PULL_UP) gpio is thus far
>> unsupported, reinstate the old cd-gpios behavior until this handling is fully
>> implemented. This permits the DHSOM to boot from SD again, without this patch
>> the card detect fails.
>
> It is strange if it is not working... I will check why the configuration is not managed
> correctly in stm32 gpio/pincontrol driver.
>
>> Signed-off-by: Marek Vasut <marex at denx.de>
>> Cc: Patrick Delaunay <patrick.delaunay at st.com>
>> Cc: Patrice Chotard <patrice.chotard at st.com>
>> ---
>> arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi
>> b/arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi
>> index 92345b7ba3..73bb5f1c6d 100644
>> --- a/arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi
>> +++ b/arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi
>> @@ -265,6 +265,9 @@
>>
>> &sdmmc1 {
>> u-boot,dm-spl;
>> + broken-cd;
>> + /delete-property/ cd-gpios;
>> + /delete-property/ disable-wp;
>> };
>>
>> &sdmmc1_b4_pins_a {
>> --
>> 2.28.0
>
> Reviewed-by: Patrick Delaunay <patrick.delaunay at st.com>
>
> But I will be try to fix the issue before to accept this patch.
>
> I will merge it only if I can't found the root cause for v2020.01-rc2....
Do you not see the same behavior on EV/DK ?
btw it is bugged in SPL.
More information about the U-Boot
mailing list