[PATCH v2 0/8] mmc: zynqmp_sdhci: Add support for Tap delay

Peng Fan peng.fan at nxp.com
Mon Oct 26 10:25:34 CET 2020


> Subject: [PATCH v2 0/8] mmc: zynqmp_sdhci: Add support for Tap delay
> 
> Hi,
> 
> this patchset adding support for Tap delay programming for ZynqMP and
> Versal.
> Based on mainline discussion also DT properties have been introduced which
> are documented here.
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ker
> nel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2F
> commit%2FDocumentation%2Fdevicetree%2Fbindings%2Fmmc%2Fmmc-cont
> roller.yaml%3Fh%3Dv5.7-rc6%26id%3Dfec81c5bca2499b4a263667860018c2
> ce47f4f51&data=04%7C01%7Cpeng.fan%40nxp.com%7C70b00e760ec8
> 4baaa65108d87744ddbe%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7
> C0%7C637390484961194901%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4
> wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&a
> mp;sdata=7xYX%2BwOybfR6qZ6cZrxLxJz75P8FILiof8oQVAjEhcg%3D&res
> erved=0
> The patchset is using these DT properties which are optional.
> Default values are also listed.
> 
> The patchset is based on:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.d
> enx.de%2Fpipermail%2Fu-boot%2F2020-May%2F410326.html&data=04
> %7C01%7Cpeng.fan%40nxp.com%7C70b00e760ec84baaa65108d87744ddbe
> %7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637390484961194
> 901%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luM
> zIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=D5gcpZ1e6gCD
> Emsy3BexqamTeesgQBN7baMMv5rlliQ%3D&reserved=0
> 
> Also new code is adding checking for SOCs which are not needed at that time
> when patch is applied (For example "mmc: zynq_sdhci: Read clock phase
> delays from dt" and IS_ENABLED(CONFIG_ARCH_ZYNQMP)...
> But I kept it there for more cleaner patches built on the top.
> 
> Thanks,
> Michal
> 
> 
> Changes in v2:
>  - Timing macro's are common to all mmc drivers, hence remove zynq_sdhci
>    from subject and description.
>  - Add common function to set tapdelays based on the values read from DT
>  - Remove tapdelay settings based on speed
> 
> Ashok Reddy Soma (6):
>   Revert "mmc: zynq: parse dt when probing"
>   mmc: Define timing macro's
>   mmc: zynq_sdhci: Set tapdelays based on clk phase delays
>   mmc: zynq_sdhci: Add clock phase delays for Versal
>   mmc: zynq_sdhci: Extend UHS timings till hs200
>   mmc: zynq_sdhci: Add common function to set input/output tapdelays
> 
> Michal Simek (2):
>   mmc: zynq_sdhci: Move macro to the top
>   mmc: zynq_sdhci: Read clock phase delays from dt
> 
>  board/xilinx/zynqmp/tap_delays.c | 199 +++------------
>  drivers/mmc/sdhci.c              |   3 +-
>  drivers/mmc/zynq_sdhci.c         | 406
> +++++++++++++++++++++++++++++--
>  include/mmc.h                    |  13 +
>  include/sdhci.h                  |   1 +
>  include/zynqmp_tap_delay.h       |   5 +-
>  6 files changed, 434 insertions(+), 193 deletions(-)
> 
> --

Reviewed-by: Peng Fan <peng.fan at nxp.com>




More information about the U-Boot mailing list