[PATCH v2 5/5] sunxi: add drivers and configs needed for LCD display

[Maxime Ripard]

On Sun, Oct 25, 2020 at 10:56:32AM +0100, Martin Cerveny wrote:
> 
> 
> On Mon, 19 Oct 2020, Maxime Ripard wrote:
> > On Fri, Oct 16, 2020 at 07:17:05PM +0200, Martin Cerveny wrote:
> > > Add PWM and dummy power regulator support.
> > > Modify phase of data signal for LCD display.
> > > 
> > > Signed-off-by: Martin Cerveny <m.cerveny at computer.org>
> > > ---
> > >  configs/LicheePi_Zero_defconfig | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/configs/LicheePi_Zero_defconfig b/configs/LicheePi_Zero_defconfig
> > > index 04d7b64504..ba1c085ec3 100644
> > > --- a/configs/LicheePi_Zero_defconfig
> > > +++ b/configs/LicheePi_Zero_defconfig
> > > @@ -3,5 +3,9 @@ CONFIG_ARCH_SUNXI=y
> > >  CONFIG_SPL=y
> > >  CONFIG_MACH_SUN8I_V3S=y
> > >  CONFIG_DRAM_CLK=360
> > > +CONFIG_VIDEO_LCD_DCLK_PHASE=0
> > 
> > I'm not sure you answered on that one either, but you'd need some
> > display timings as well, right? If so, why do we need that change in the
> > first place if we're expected to change it anyway?
> > 
> 
> I done in config all needed setup to enable LCD
> (PHASE and PWM drivers).
> 
> Enabling LCD (with different display timimgs) depends now only on DTS/DTB.

Indeed, I missed that one.

With that being said, it doesn't really change the fact that you'd still
need some changes to the DT (and thus the code) to enable it.

And those changes wouldn't follow the DT bindings of the display
controller either, so there's no chance of them getting upstream at any
point in time.

So yeah, while your first patches should definitely go in, this one
doesn't seem that interesting

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201026/d5c130fa/attachment.sig>