[PATCH v2 20/28] binman: Drop Entry.CheckOffset()

Simon Glass sjg at chromium.org
Tue Oct 27 00:40:18 CET 2020


This function just calls CheckEntries() in the only non-trivial
implementation. Drop it and use CheckEntries() directly.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

(no changes since v1)

 tools/binman/entry.py         | 2 +-
 tools/binman/etype/section.py | 5 +----
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/tools/binman/entry.py b/tools/binman/entry.py
index 8fa1dcef2da..8946d2bc02f 100644
--- a/tools/binman/entry.py
+++ b/tools/binman/entry.py
@@ -520,7 +520,7 @@ class Entry(object):
         """
         pass
 
-    def CheckOffset(self):
+    def CheckEntries(self):
         """Check that the entry offsets are correct
 
         This is used for entries which have extra offset requirements (other
diff --git a/tools/binman/etype/section.py b/tools/binman/etype/section.py
index 2812989ba1a..fb4bf640bfb 100644
--- a/tools/binman/etype/section.py
+++ b/tools/binman/etype/section.py
@@ -296,7 +296,7 @@ class Entry_section(Entry):
         offset = 0
         prev_name = 'None'
         for entry in self._entries.values():
-            entry.CheckOffset()
+            entry.CheckEntries()
             if (entry.offset < self._skip_at_start or
                     entry.offset + entry.size > self._skip_at_start +
                     self.size):
@@ -337,9 +337,6 @@ class Entry_section(Entry):
                 sizes_ok = False
         return sizes_ok and sizes_ok_base
 
-    def CheckOffset(self):
-        self.CheckEntries()
-
     def WriteMap(self, fd, indent):
         """Write a map of the section to a .map file
 
-- 
2.29.0.rc2.309.g374f81d7ae-goog



More information about the U-Boot mailing list