[PATCH 2/2] rockchip: gru: Allow setting up clocks in U-Boot proper

Simon Glass sjg at chromium.org
Tue Oct 27 05:52:22 CET 2020


Hi Alper,

On Sat, 24 Oct 2020 at 16:29, Alper Nebi Yasak <alpernebiyasak at gmail.com> wrote:
>
> On 24/10/2020 03:05, Simon Glass wrote:
> > Hi Alper,
> >
> > On Thu, 22 Oct 2020 at 14:38, Alper Nebi Yasak <alpernebiyasak at gmail.com> wrote:
> >>
> >> Commit fe974716326c ("rockchip: rk3288: Allow setting up clocks in
> >> U-Boot proper") fixes some clock issues when chainloading U-Boot on
> >> rk3288 chromebooks. Part of that change is still available in veyron's
> >> board_early_init_r() function. Since chain-loading U-Boot proper from
> >> vendor firmware is possible on gru boards as well, do the same thing for
> >> them too.
> >>
> >> Signed-off-by: Alper Nebi Yasak <alpernebiyasak at gmail.com>
> >> ---
> >>
> >>  board/google/gru/gru.c           | 23 +++++++++++++++++++++++
> >>  configs/chromebook_bob_defconfig |  1 +
> >>  2 files changed, 24 insertions(+)
> >
> > Similar comment here.
>
> I can do the same HANDOFF checks here, but to me it looks like this
> wouldn't need them if we're already checking things in the probe
> function.

Yes I thnk so.

Regards,
Simon


More information about the U-Boot mailing list