[PATCH v2 13/28] binman: Move section-building code into a function

Simon Glass sjg at chromium.org
Fri Oct 30 04:33:58 CET 2020


Create a new _BuildSectionData() to hold the code that is now in
GetData(), so that it is clearly separated from entry.GetData() base
function.

Separate out the 'pad-before' processing to make this easier to
understand.

Unfortunately this breaks the testDual test. Rather than squash several
patches into an un-reviewable glob, disable the test for now.

This also affects testSkipAtStartSectionPad(), although it still not
quite what it should be. Update that temporarily for now.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

Changes in v2:
- Use unittest.skip() to skip testDual()
- Update testSkipAtStartSectionPad() for new behaviour

 tools/binman/etype/section.py | 35 +++++++++++++++++++++++++++++------
 tools/binman/ftest.py         |  4 ++--
 2 files changed, 31 insertions(+), 8 deletions(-)

Applied to u-boot-dm, thanks!


More information about the U-Boot mailing list