[PATCH] configs: powerpc: Don't set CONFIG_ENV_ADDR for T2080RDB_SPIFLASH

Chris Packham judge.packham at gmail.com
Fri Sep 4 08:01:44 CEST 2020


On Fri, 4 Sep 2020, 12:16 AM Tom Rini, <trini at konsulko.com> wrote:

> On Thu, Sep 03, 2020 at 12:02:06PM +1200, Chris Packham wrote:
>
> > Setting CONFIG_ENV_ADDR to something other than 0 stops gd->env_addr
> > from being allocated dynamically. When the environment is in SPI we need
> > it to be allocated as we can't use a direct memory mapped address.
> >
> > Signed-off-by: Chris Packham <judge.packham at gmail.com>
> > ---
> >
> >  configs/T2080RDB_SPIFLASH_defconfig | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/configs/T2080RDB_SPIFLASH_defconfig
> b/configs/T2080RDB_SPIFLASH_defconfig
> > index 62cbab1f0734..ba4ac1010502 100644
> > --- a/configs/T2080RDB_SPIFLASH_defconfig
> > +++ b/configs/T2080RDB_SPIFLASH_defconfig
> > @@ -50,7 +50,6 @@
> CONFIG_MTDPARTS_DEFAULT="mtdparts=fe8000000.nor:1m(uboot),5m(kernel),128k(dtb),9
> >  CONFIG_OF_CONTROL=y
> >  CONFIG_ENV_OVERWRITE=y
> >  CONFIG_ENV_IS_IN_SPI_FLASH=y
> > -CONFIG_ENV_ADDR=0xFFFC9000
> >  CONFIG_DM=y
> >  CONFIG_FSL_CAAM=y
> >  CONFIG_DM_I2C=y
>
> Thanks for figuring that out.  There's a handful of _SPIFLASH defconfigs
> that do the exact same thing, from the same conversion (I probably did
> it) to defconfig.  It's likely that they're all wrong, yes?
>

More than likely yes. I've only got a T2080RDB to test with but I can whip
up a patch to make the same change to the other affected defconfigs.


More information about the U-Boot mailing list