[PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE

Heinrich Schuchardt xypron.glpk at gmx.de
Sun Sep 6 21:33:04 CEST 2020


On 9/6/20 9:00 PM, Andre Heider wrote:
> On 05/09/2020 12:02, Heinrich Schuchardt wrote:
>> Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not
>> used
>> for espresso7420_defconfig.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>
> I noticed that too while grepping for CONFIG_DEFAULT_CONSOLE. Afaict
> there're quite some boards with it set but unused:

Thanks for reviewing. As the boards have different maintainers we should
treat them in separate patches.

Best regards

Heinrich

> include/configs/arndale.h
> include/configs/peach-pi.h
> include/configs/peach-pit.h
> include/configs/smdk5250.h
> include/configs/smdkv310.h
> include/configs/snow.h
> include/configs/spring.h
>
> This one even defines it twice (looks like a rebase gone wrong), still
> unused:
> include/configs/smdk5420.h
> #define CONFIG_DEFAULT_CONSOLE    "console=ttySAC1,115200n8\0"
> #define CONFIG_DEFAULT_CONSOLE        "console=ttySAC1,115200n8\0"
>
> Last but not least:
> include/configs/origen.h
> #define CONFIG_DEFAULT_CONSOLE        "console=ttySAC1,115200n8\0"
> "console=ttySAC2,115200n8\0"
>
> Btw, *all* hits for CONFIG_DEFAULT_CONSOLE are ttySAC*.
>
> Regards,
> Andre
>
>> ---
>>   include/configs/espresso7420.h | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/include/configs/espresso7420.h
>> b/include/configs/espresso7420.h
>> index 5aeb009f03..2495db93f8 100644
>> --- a/include/configs/espresso7420.h
>> +++ b/include/configs/espresso7420.h
>> @@ -18,9 +18,6 @@
>>   #define CONFIG_SPL_STACK        CONFIG_IRAM_END
>>   #define CONFIG_SYS_INIT_SP_ADDR        CONFIG_IRAM_END
>>
>> -/* select serial console configuration */
>> -#define CONFIG_DEFAULT_CONSOLE    "console=ttySAC1,115200n8\0"
>> -
>>   /* DRAM Memory Banks */
>>   #define SDRAM_BANK_SIZE        (256UL << 20UL)    /* 256 MB */
>>
>> --
>> 2.28.0
>>
>



More information about the U-Boot mailing list