[PATCH v3 01/12] binman: Allow entry args to be required

Simon Glass sjg at chromium.org
Mon Sep 7 15:57:13 CEST 2020


Hi Michal,

On Mon, 7 Sep 2020 at 00:31, Michal Simek <michal.simek at xilinx.com> wrote:
>
> Hi Simon,
>
> On 05. 09. 20 23:10, Simon Glass wrote:
> > If an entry argument is needed by an entry but the entry argument is not
> > present, then a strange error can occur when trying to read the file.
> >
> > Fix this by allowing arguments to be required. Select this option for the
> > cros-ec-rw entry. If a filename is provided in the node, allow that to be
> > used.
> >
> > Also tidy up a few related tests to make the error string easier to find,
> > and fully ignore unused return values.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> > (no changes since v1)
> >
> >  tools/binman/README.entries             |  7 ++++++-
> >  tools/binman/etype/blob_named_by_arg.py | 10 ++++++----
> >  tools/binman/etype/cros_ec_rw.py        |  3 +--
> >  tools/binman/ftest.py                   | 15 +++++++++++----
> >  4 files changed, 24 insertions(+), 11 deletions(-)
> >
> > Applied to u-boot-dm/next, thanks!
>
> Did you start to use patman for sending this?
> Just curios because I am missing indentation in origin message.

No that is done with a gmail script.  It would be interesting to use
patman though. I am using patman to collect review tags from
patchwork, so using it to send out the 'applied' emails would help
complete the circle.

Regards,
Simon


More information about the U-Boot mailing list