[PATCH v3 9/9] usb: xhci: convert to readx_poll_sleep_timeout()

Tom Rini trini at konsulko.com
Wed Sep 9 16:16:29 CEST 2020


On Wed, Sep 09, 2020 at 10:05:42PM +0800, Bin Meng wrote:
> On Wed, Sep 9, 2020 at 10:02 PM Marek Vasut <marex at denx.de> wrote:
> >
> > On 9/9/20 3:46 PM, Bin Meng wrote:
> > > On Wed, Sep 9, 2020 at 7:05 PM Marek Vasut <marex at denx.de> wrote:
> > >>
> > >> On 9/9/20 3:55 AM, Bin Meng wrote:
> > >>> Hi Marek,
> > >>
> > >> Hi,
> > >>
> > >>> On Wed, Sep 9, 2020 at 12:15 AM Marek Vasut <marex at denx.de> wrote:
> > >>>>
> > >>>> On 9/8/20 5:45 PM, Bin Meng wrote:
> > >>>>> Hi Marek,
> > >>>>
> > >>>> Hi,
> > >>>>
> > >>>>> On Tue, Sep 8, 2020 at 7:13 PM Marek Vasut <marex at denx.de> wrote:
> > >>>>>>
> > >>>>>> On 9/8/20 3:44 AM, Bin Meng wrote:
> > >>>>>>> On Mon, Sep 7, 2020 at 3:14 PM Chunfeng Yun <chunfeng.yun at mediatek.com> wrote:
> > >>>>>>>>
> > >>>>>>>> Use readx_poll_sleep_timeout() to poll the register status
> > >>>>>>>>
> > >>>>>>>> Signed-off-by: Chunfeng Yun <chunfeng.yun at mediatek.com>
> > >>>>>>>> ---
> > >>>>>>>> v3: no changes
> > >>>>>>>>
> > >>>>>>>> v2: fix typo of title suggested by Frank
> > >>>>>>>> ---
> > >>>>>>>>  drivers/usb/host/xhci.c | 25 +++++++++++--------------
> > >>>>>>>>  1 file changed, 11 insertions(+), 14 deletions(-)
> > >>>>>>>>
> > >>>>>>>
> > >>>>>>> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> > >>>>>>
> > >>>>>> Thanks. So now I have half of a RESEND patchset with RB tags, and
> > >>>>>> another half of just RB tags without patchset. Can someone of you please
> > >>>>>> collect the tags and resend the patchset once more with the collected
> > >>>>>> tags, so it's all in one place ?
> > >>>>>>
> > >>>>>
> > >>>>> I believe the latest version has all the RB tags.
> > >>>>
> > >>>> Thank you, I cannot apply a patchset which only has "Re:" in my mailbox,
> > >>>> because the original patches are just not there.
> > >>>
> > >>> You can use patchwork to help the custodian work. I found it very
> > >>> helpful to download the patches from patchwork and apply.
> > >>
> > >> Can you also comment on patches via patchwork ?
> > >>
> > >> I mean, really, can we please just stick to the usual workflow ? That's
> > >> all I am asking for , nothing else, nothing new.
> > >
> > > I don't understand the question about "usual workflow". You asked "I
> > > cannot apply a patchset which only has "Re:" in my mailbox" and I
> > > recommended patchwork which will satisfy the requirement of what you
> > > asked.
> >
> > Right, I can, but if there is more I want to say about the patch, I
> > cannot do it with patchwork. Then I need the patch, which I don't have.
> > Hence my remark about the usual email-based workflow.
> 
> Yes, that's true. If we need to post comments about patches, we will
> have to use email.

Which, to close the loop, is trivial with patchwork, if you're making a
new comment, and hard if you are trying to join an ongoing conversation.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200909/dc079d0c/attachment.sig>


More information about the U-Boot mailing list