[PATCH 2/2] x86: acpi: Add memset to initialize SPCR table

Simon Glass sjg at chromium.org
Wed Sep 9 16:35:18 CEST 2020


On Wed, 9 Sep 2020 at 06:33, Wolfgang Wallner
<wolfgang.wallner at br-automation.com> wrote:
>
> Add a missing memset to acpi_create_spcr().
>
> The other acpi_create_xxxx() functions perform a memset on their
> structures, acpi_create_spcr() does not and as a result the contents of
> this table are partly uninitialized (and thus random after every reset).
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner at br-automation.com>
> ---
>
>  arch/x86/lib/acpi_table.c | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Simon Glass <sjg at chromium.org>

For further thought, I do wonder if acpi_fill_header() should do the
memset, if sizeof() could be passed as a parameter?


More information about the U-Boot mailing list