[PATCH] efi: change usage syntax

Heinrich Schuchardt xypron.glpk at gmx.de
Tue Sep 15 14:25:22 CEST 2020


On 28.08.20 21:20, Maxim Uvarov wrote:
> syntax was changed from "," to ":". Account this also
> in the documentation.

Thank you for the patch.

For future contributions, please, use scripts/get_maintainer.pl to
determine who should be on copy.

> Fixes: 2b3fbcb59f efi_loader: use ':' as separator for setenv -i

Nits: We would normally write this as
Fixes: 2b3fbcb59f41 ("efi_loader: use ':' as separator for setenv -i")

>
> Signed-off-by: Maxim Uvarov <maxim.uvarov at linaro.org>

I will also correct the following line when merging:

diff --git a/cmd/nvedit.c b/cmd/nvedit.c
index 63b0c5f802..7fce723800 100644
--- a/cmd/nvedit.c
+++ b/cmd/nvedit.c
@@ -1541,7 +1541,7 @@ U_BOOT_CMD_COMPLETE(
        "set environment variables",
 #if defined(CONFIG_CMD_NVEDIT_EFI)
        "-e [-guid guid][-nv][-bs][-rt][-at][-a][-v]\n"
-       "        [-i addr,size name], or [name [value ...]]\n"
+       "        [-i addr:size name], or [name [value ...]]\n"
        "    - set UEFI variable 'name' to 'value' ...'\n"
        "      \"-guid\": GUID xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx\n"
        "      \"-nv\": set non-volatile attribute\n"

Reviewed-by: Heinrich Schuchardt <xypron.glpk at gmx.de>

> ---
>  cmd/nvedit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmd/nvedit.c b/cmd/nvedit.c
> index d188c6aa6b..d03accead9 100644
> --- a/cmd/nvedit.c
> +++ b/cmd/nvedit.c
> @@ -1472,7 +1472,7 @@ static char env_help_text[] =
>  	"env select [target] - select environment target\n"
>  #endif
>  #if defined(CONFIG_CMD_NVEDIT_EFI)
> -	"env set -e [-nv][-bs][-rt][-at][-a][-i addr,size][-v] name [arg ...]\n"
> +	"env set -e [-nv][-bs][-rt][-at][-a][-i addr:size][-v] name [arg ...]\n"
>  	"    - set UEFI variable; unset if '-i' or 'arg' not specified\n"
>  #endif
>  	"env set [-f] name [arg ...]\n";
>



More information about the U-Boot mailing list