[PATCH v2 02/46] firmware: ti_sci: Fix not calling dev_err with a device

Nishanth Menon nm at ti.com
Wed Sep 16 03:26:38 CEST 2020


On 10:44-20200915, Sean Anderson wrote:
> This converts calls to dev_err to get the device from ti_sci_info where
> appropriate.
> 
> Signed-off-by: Sean Anderson <seanga2 at gmail.com>
> ---
> 
> Changes in v2:
> - New
> 
>  drivers/firmware/ti_sci.c | 23 ++++++++++++++++-------
>  1 file changed, 16 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index e311f55ef8..a2beb0079d 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -619,7 +619,7 @@ static int ti_sci_get_device_state(const struct ti_sci_handle *handle,
>  
>  	ret = ti_sci_do_xfer(info, xfer);
>  	if (ret) {
> -		dev_err(dev, "Mbox send fail %d\n", ret);
> +		dev_err(info->dev, "Mbox send fail %d\n", ret);
>  		return ret;
>  	}
>  
> 
[...]
Aaah. Thanks.
Reviewed-by: Nishanth Menon <nm at ti.com>

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


More information about the U-Boot mailing list