[PATCH 2/4] net: mdio: Supply appropriate devices for dev_dgb calls

Sean Anderson seanga2 at gmail.com
Thu Sep 17 03:40:26 CEST 2020


On 9/16/20 9:09 PM, Simon Glass wrote:
> On Sat, 12 Sep 2020 at 18:28, Sean Anderson <seanga2 at gmail.com> wrote:
>>
>> The name of the device we are working on is `ethdev` and not just `dev`.
>>
>> Signed-off-by: Sean Anderson <seanga2 at gmail.com>
>> ---
>>
>>  net/mdio-uclass.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> BTW I really like using 'dev' for the struct udevice if there is only
> one, and other names for other things (e.g. edev for Ethernet, udev
> for USB).
> 

Yeah, I think it is only really necessary when disambiguating between
several different devices. However, I am trying to make these patches as
minimal as possible, so I would like to keep the variable names the same
where possible.

--Sean


More information about the U-Boot mailing list