[PATCH v1] cmd: acpi: Print revisions in hex format

[Andy Shevchenko]

On Mon, Sep 21, 2020 at 10:20:18AM +0800, Bin Meng wrote:
> On Tue, Sep 8, 2020 at 10:30 PM Andy Shevchenko
> <andriy.shevchenko at linux.intel.com> wrote:
> >
> > The revisions are usually dates in hex-decimal format representing
> > YYYYmmdd. Print them in hex to see this clearly.
> >
> > Before:
> >   ...
> >   FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 538970376 INTL 0)
> >   DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 65536 INTL 538968870)
> >   ...
> > After:
> >   ...
> >   FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 20200908 INTL 0)
> >   DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 10000 INTL 20200326)
> >   ...
> >
> > Fixes: 0b885bcfd9b0 ("acpi: Add an acpi command")
> > Cc: Wolfgang Wallner <wolfgang.wallner at br-automation.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> > ---
> >  cmd/acpi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/cmd/acpi.c b/cmd/acpi.c
> > index 085a3a650d1a..a3419b42b556 100644
> > --- a/cmd/acpi.c
> > +++ b/cmd/acpi.c
> > @@ -26,7 +26,7 @@ static void dump_hdr(struct acpi_table_header *hdr)
> >         printf("%.*s %08lx %06x", ACPI_NAME_LEN, hdr->signature,
> >                (ulong)map_to_sysmem(hdr), hdr->length);
> >         if (has_hdr) {
> > -               printf(" (v%02d %.6s %.8s %u %.4s %d)\n", hdr->revision,
> > +               printf(" (v%02d %.6s %.8s %x %.4s %x)\n", hdr->revision,
> >                        hdr->oem_id, hdr->oem_table_id, hdr->oem_revision,
> >                        hdr->aslc_id, hdr->aslc_revision);
> >         } else {
> > --
> 
> This unfortunately breaks the unit test.
> 
> /u/test/dm/acpi.c:371, dm_test_acpi_cmd_list(): console:
> Expected 'RSDT 0570ebf0 000030 (v01 U-BOOT U-BOOTBL 538970401 INTL 0)',
> got 'RSDT 0570ebf0 000030 (v01 U-BOOT U-BOOTBL 20200921 INTL 0)'
> Failures: 2
> 
> Would you please resend v2 to fix this?

v2 has been just sent. Thanks!

-- 
With Best Regards,
Andy Shevchenko