[PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support

[Heiko Schocher]

Hi Rasmus,

Am 21.09.2020 um 10:40 schrieb Rasmus Villemoes:
> On 17/09/2020 06.24, Heiko Schocher wrote:
>> Hello Rasmus,
>>
>> Am 16.09.2020 um 21:35 schrieb Rasmus Villemoes:
>>>
>>> We have a mpc8309-based board, currently using a U-Boot based on
>>> v2020.04. If you have a git tree I can pull these patches from I'll try
>>> to test them on our hardware.
>>
>> Pushed them (rebased to next) to:
>>
>> https://github.com/hsdenx/u-boot-test/tree/kmcoge5ne-dm-ethernet-devel
>>
>> started travis build for this branch:
>> https://travis-ci.org/github/hsdenx/u-boot-test/builds/727904421
> 
> Thanks, it took me a bit longer rebasing our private patches to -next
> than I thought, but I'm starting to look at those now. The first thing I
> notice is this:
> 
> -       u32                     pin_2bit_mask;
> -       u32                     pin_2bit_dir;
> -       u32                     pin_2bit_assign;
> -       u32                     pin_1bit_mask;
> +       u32             2bit_mask;
> +       u32             2bit_dir;
> +       u32             2bit_assign;
> +       u32             1bit_mask;
> 
> That doesn't compile (can't start identifier with digit), but you fix it

Autsch ...

> up later. Any chance you can make these patches bisectable? Especially a
> patch that claims to be about fixing coding style shouldn't introduce
> build errors.

I am sorry about that, but Tom already pulled the patches into next...

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de