[PATCH 1/2] video: backlight: Support PWMs without a known period_ns

Simon Glass sjg at chromium.org
Thu Sep 24 18:08:06 CEST 2020


Hi Alper,

On Wed, 23 Sep 2020 at 10:52, Alper Nebi Yasak <alpernebiyasak at gmail.com> wrote:
>
> The PWM device provided by Chrome OS EC doesn't really support anything
> other than setting a relative duty cycle. To support it as a backlight,
> this patch makes the PWM period optional in the device tree and pretends
> the valid brightness range is its period_ns.
>
> Signed-off-by: Alper Nebi Yasak <alpernebiyasak at gmail.com>
> ---
>
>  drivers/video/pwm_backlight.c | 20 ++++++++++++++------
>  1 file changed, 14 insertions(+), 6 deletions(-)

This looks OK.

But please update the comment for pwm_set_config() to describe the
param updates and add a sandbox test to pwm.c

Does this affect the devicetree binding?

Regards,
Simon


More information about the U-Boot mailing list