[PATCH 1/1] clk: kendryte: no need to check argument of free()

Sean Anderson seanga2 at gmail.com
Tue Sep 29 22:06:54 CEST 2020


On 9/29/20 3:52 PM, Heinrich Schuchardt wrote:
> free() checks if its argument is NULL. No need to check it twice.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
>  drivers/clk/kendryte/clk.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/kendryte/clk.c b/drivers/clk/kendryte/clk.c
> index 981b3b7699..26139fd804 100644
> --- a/drivers/clk/kendryte/clk.c
> +++ b/drivers/clk/kendryte/clk.c
> @@ -471,8 +471,7 @@ cleanup_gate:
>  cleanup_div:
>  	free(div);
>  cleanup_mux:
> -	if (mux)
> -		free(mux);
> +	free(mux);
>  	return comp;
>  }
> 
> --
> 2.28.0
> 

LGTM

Reviewed-by: Sean Anderson <seanga2 at gmail.com>


More information about the U-Boot mailing list