[PATCH v3 15/28] usb: ehci-mx6: Drop assignment of sequence number

[Simon Glass]

Hi Marek,

On Thu, 1 Apr 2021 at 08:27, Tom Rini <trini at konsulko.com> wrote:
>
> On Wed, Mar 31, 2021 at 09:14:42PM +0200, Marek Vasut wrote:
> > On 12/19/20 5:40 PM, Simon Glass wrote:
> > > This hack cannot work in the new sequence-numbering scheme. Remove it
> > > while we wait for the maintainer to complete DM conversion as noted in
> > > the existing comment.
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org>
> > > ---
> > >
> > > (no changes since v1)
> > >
> > >   drivers/usb/host/ehci-mx6.c | 12 +++++++++---
> > >   1 file changed, 9 insertions(+), 3 deletions(-)
> > >
> > > Applied to u-boot-dm/next, thanks!
> >
> > Note that this broke USB on iMX6, iMX7 and iMX8M, which are all commonly
> > used embedded platforms. It was difficult to spot this USB patch hidden
> > between all the other dm patches. Also, it seems this didn't get
> > reviewed/acked by any NXP maintainer. Frankly, this is not good. I'm adding
> > NXP on CC.

I agree, but perhaps for different reasons. The migration deadline was
over 18 months ago and patch was (presumably?) copied to the right
maintainers, at least the first time. Having said that, I don't see an
entry for this driver, so it might have just been going on git
history?

It worries me that on such an important platform, the migration has
stalled for so long. It might be worth doing an audit of what else is
there.

>
> And the "gonna start deleting stuff" deadline for DM_USB is after
> v2021.07 not after v2021.04.
>
> --
> Tom

Regards,
Simon
-------------- next part --------------
-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmBkzTUACgkQFHw5/5Y0
tywqUwv8Cz7rqux8ggHo19a9ANx77HZ8/0Hp43EMNWMbTsVFqfmE1EXK0bzgA1z9
E9XoBfsgWrTxj5/SDaC5n9tKS4Jd4DKXWCM7OscdhDdTnXXPm/F7Y93y2Dn5gJJW
d5p4NDMTf058sJ47YN/O6Ag30Q+DKhQCLC5i5WO0gEyDnRaQXFL0MaVqm3QPiDi8
SBWEh7JYfuthEI7surYHygqIW19zA/fcau5MXmcedMws+VN/Cjr9pfypZu8TYSdg
H8g651zwu/4o/Q2+/iX6ASx1m3BOq1HU3gTChLHjz1RSdjRByuLB16pSxMqXP8wE
WLqrdW6XeqybrTt0wTUG++FdONbfKEfSjQ6QC1Hn6nF+OXvP1DiWa6PmV0KU8vRw
zpUlkEAaInxZKLkdnqfqqwi43uSQMCrmLS8mBcsi/U6CP6mDi+G75B/41sWrbvHG
ubXdVoR2Z4hVAGNqwp9SZ8LCmZ84wbkJ1ybdughvRDMqnG43G7EfBRAXzyjgKj9N
wDQjQxyj
=GMjc
-----END PGP SIGNATURE-----