[PATCH 05/11] arm: dts: imx6qdl-gw*: add dr_mode prop to dt to avoid error

[Peter Robinson]

On Mon, Mar 1, 2021 at 10:34 PM Tim Harvey <tharvey at gateworks.com> wrote:
>
> The fsl-usb dt bindings in Linux default dr_mode to 'host' for
> backward compatibility however U-Boot prints an error if
> this property does not exist. Declare it in the Gateworks
> Ventana device-trees to avoid the error.

Is there any reason not to fix the driver not to error if this
property is missing rather than working around it like this?

> Signed-off-by: Tim Harvey <tharvey at gateworks.com>
> ---
>  arch/arm/dts/imx6qdl-gw51xx.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw52xx.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw53xx.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw54xx.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw551x.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw552x.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw553x.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw560x.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw5903.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw5904.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw5907.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw5910.dtsi | 1 +
>  arch/arm/dts/imx6qdl-gw5913.dtsi | 1 +
>  13 files changed, 13 insertions(+)
>
> diff --git a/arch/arm/dts/imx6qdl-gw51xx.dtsi b/arch/arm/dts/imx6qdl-gw51xx.dtsi
> index 3c04b5a4f3..2a21c6731e 100644
> --- a/arch/arm/dts/imx6qdl-gw51xx.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw51xx.dtsi
> @@ -450,6 +450,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw52xx.dtsi b/arch/arm/dts/imx6qdl-gw52xx.dtsi
> index 959d8ac2e3..de54b7c217 100644
> --- a/arch/arm/dts/imx6qdl-gw52xx.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw52xx.dtsi
> @@ -544,6 +544,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw53xx.dtsi b/arch/arm/dts/imx6qdl-gw53xx.dtsi
> index 8072ed47c6..64bb88dc74 100644
> --- a/arch/arm/dts/imx6qdl-gw53xx.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw53xx.dtsi
> @@ -541,6 +541,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw54xx.dtsi b/arch/arm/dts/imx6qdl-gw54xx.dtsi
> index 8c9bcdd398..56d090ec0f 100644
> --- a/arch/arm/dts/imx6qdl-gw54xx.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw54xx.dtsi
> @@ -611,6 +611,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw551x.dtsi b/arch/arm/dts/imx6qdl-gw551x.dtsi
> index e5d803d023..1bb586cbd5 100644
> --- a/arch/arm/dts/imx6qdl-gw551x.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw551x.dtsi
> @@ -536,6 +536,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw552x.dtsi b/arch/arm/dts/imx6qdl-gw552x.dtsi
> index 290a607fed..5462907f12 100644
> --- a/arch/arm/dts/imx6qdl-gw552x.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw552x.dtsi
> @@ -402,6 +402,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw553x.dtsi b/arch/arm/dts/imx6qdl-gw553x.dtsi
> index c15b9cc63b..b6965f25da 100644
> --- a/arch/arm/dts/imx6qdl-gw553x.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw553x.dtsi
> @@ -509,6 +509,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw560x.dtsi b/arch/arm/dts/imx6qdl-gw560x.dtsi
> index 093a219a77..d5468fb260 100644
> --- a/arch/arm/dts/imx6qdl-gw560x.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw560x.dtsi
> @@ -656,6 +656,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw5903.dtsi b/arch/arm/dts/imx6qdl-gw5903.dtsi
> index e1c8dd233c..78f9ec90b7 100644
> --- a/arch/arm/dts/imx6qdl-gw5903.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw5903.dtsi
> @@ -531,6 +531,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "host";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw5904.dtsi b/arch/arm/dts/imx6qdl-gw5904.dtsi
> index 3cd2e717c1..52b255b726 100644
> --- a/arch/arm/dts/imx6qdl-gw5904.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw5904.dtsi
> @@ -583,6 +583,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw5907.dtsi b/arch/arm/dts/imx6qdl-gw5907.dtsi
> index 21c68a55bc..c8b29246b7 100644
> --- a/arch/arm/dts/imx6qdl-gw5907.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw5907.dtsi
> @@ -378,6 +378,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw5910.dtsi b/arch/arm/dts/imx6qdl-gw5910.dtsi
> index ed4e222599..56d0c4ff6c 100644
> --- a/arch/arm/dts/imx6qdl-gw5910.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw5910.dtsi
> @@ -398,6 +398,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "host";
>         status = "okay";
>  };
>
> diff --git a/arch/arm/dts/imx6qdl-gw5913.dtsi b/arch/arm/dts/imx6qdl-gw5913.dtsi
> index 4cd7d290f5..9fae4cccd7 100644
> --- a/arch/arm/dts/imx6qdl-gw5913.dtsi
> +++ b/arch/arm/dts/imx6qdl-gw5913.dtsi
> @@ -343,6 +343,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> +       dr_mode = "host";
>         status = "okay";
>  };
>
> --
> 2.17.1
>