[PATCH v1 08/23] phy: marvell: add RX training command

[Stefan Roese]

Hi Marek,

On 24.03.21 18:46, Marek Behun wrote:
> On Wed, 24 Mar 2021 15:06:34 +0100
> Stefan Roese <sr at denx.de> wrote:
> 
>> From: Igal Liberman <igall at marvell.com>
>>
>> This patch adds support for running RX training using new command called
>> "rx_training"
>> Usage:
>> rx_training - rx_training <cp id> <comphy id>
>>
>> RX training allows to improve link quality (for SFI mode)
>> by running training sequence between us and the link partner,
>> this allows to reach better link quality then using static configuration.
> 
> PLEASE do not add another vendor specific command. PLEASE !

Why not? We have many vendor specific commands in U-Boot. We also have
board specific commands as well.

I agree that generic / common commands should be implemented in a way,
that they can be used by all platforms. But this is not possible or
for all commands. And this command does not look very "generic" at least
not to me.

> Create a generic command, with name 'ddr' or something, with API and
> documentation.
> 
> Also the name "rx_training" is the worst thing ever. It could be
> interpreted as training for RX on ethernet PHY, or even on UART.

"RX" is of course not very specific, I agree. AFAICT, only
comphy_cp110_sfi_rx_training() is supported (right now). Not sure if
this will be extended at a later time. Perhaps using something like
"comphy_rx_training" would be more suitable?

Thanks,
Stefan