[PATCH v1 1/2] cmd: bind: Fix driver binding on a device

Andy Shevchenko andy.shevchenko at gmail.com
Fri Apr 9 11:48:32 CEST 2021


On Fri, Apr 9, 2021 at 12:28 PM Patrice CHOTARD
<patrice.chotard at foss.st.com> wrote:
> On 4/9/21 11:16 AM, Andy Shevchenko wrote:
> > On Fri, Apr 9, 2021 at 10:37 AM Patrice Chotard
> > <patrice.chotard at foss.st.com> wrote:

...

> >> +                       if (drv) {
> >> +                               if (drv == entry)
> >> +                                       break;
> >
> >> +                       } else {
> >> +                               if (!ret)
> >> +                                       break;
> >> +                       }
> >
> > This can be simplified to
> > } else if (!ret)
> >   break;
>
> I know but checkpatch.pl requested it ;-)

You mean it doesn't recognize 'else if' construction? Then it's a bug
there for sure.

-- 
With Best Regards,
Andy Shevchenko


More information about the U-Boot mailing list