[PATCH v3 02/11] clk: k210: Fix PLLs not being enabled
Damien Le Moal
Damien.LeMoal at wdc.com
Fri Apr 9 04:45:59 CEST 2021
On 2021/04/09 11:13, Sean Anderson wrote:
> After starting or setting the rate of a PLL, the enable bit must be set.
>
> This fixes a bug where the AI ram would not be accessible, because it
> requires PLL1 to be running.
>
> Signed-off-by: Sean Anderson <seanga2 at gmail.com>
> ---
>
> (no changes since v1)
>
> drivers/clk/kendryte/pll.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/kendryte/pll.c b/drivers/clk/kendryte/pll.c
> index ab6d75d585..f198920113 100644
> --- a/drivers/clk/kendryte/pll.c
> +++ b/drivers/clk/kendryte/pll.c
> @@ -531,6 +531,7 @@ static int k210_pll_enable(struct clk *clk)
> k210_pll_waitfor_lock(pll);
>
> reg &= ~K210_PLL_BYPASS;
> + reg |= K210_PLL_EN;
> writel(reg, pll->reg);
>
> return 0;
> @@ -550,6 +551,7 @@ static int k210_pll_disable(struct clk *clk)
> writel(reg, pll->reg);
>
> reg &= ~K210_PLL_PWRD;
> + reg &= ~K210_PLL_EN;
> writel(reg, pll->reg);
> return 0;
> }
>
Looks good. That matches what the linux driver is doing.
Reviewed-by: Damien Le Moal <damien.lemoal at wdc.com>
--
Damien Le Moal
Western Digital Research
More information about the U-Boot
mailing list