[PATCH 1/2] arm: dts: bcm283x: Add minimal smbios information

Fabian Vogt fvogt at suse.com
Fri Apr 9 15:13:25 CEST 2021


Am Freitag, 9. April 2021, 14:35:10 CEST schrieb matthias.bgg at kernel.org:
> From: Matthias Brugger <mbrugger at suse.com>
> 
> At present SMBIOS tables are emtpy,
                                 ^ typo

> which breaks some use-cases that rely on that.
Can you give an example?

> Add some minimal information to
Isn't it possible to get the complete information from the firmware here?
That would allow to have the correct product and serial at least.
If that's not possible or too complex, then I suggest to use the proper
strings, e.g. "Raspberry Pi", as those are user visible.

> fullfill this.
    ^ typo
 
> Signed-off-by: Matthias Brugger <mbrugger at suse.com>
> ---
> 
>  arch/arm/dts/bcm283x-u-boot.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm/dts/bcm283x-u-boot.dtsi b/arch/arm/dts/bcm283x-u-boot.dtsi
> index 68d03627f4..f5235cb083 100644
> --- a/arch/arm/dts/bcm283x-u-boot.dtsi
> +++ b/arch/arm/dts/bcm283x-u-boot.dtsi
> @@ -6,6 +6,26 @@
>   * (C) Copyright 2016 Fabian Vogt <fvogt at suse.com>
>   */
>  
> +/ {
> +	smbios {
> +		compatible = "u-boot,sysinfo-smbios";
> +		smbios {
> +			system {
> +				manufacturer = "raspberrypi";
> +				product = "rpi";
> +			};
> +			baseboard {
> +				manufacturer = "raspberrypi";
> +				product = "rpi";
> +			};
> +			chassis {
> +				manufacturer = "raspberrypi";
> +				product = "rpi";

According to doc/device-tree-bindings/sysinfo/smbios.txt, "chassis"
doesn't have a "product".

Cheers,
Fabian

> +			};
> +		};
> +	};
> +};
> +
>  &uart0 {
>  	skip-init;
>  	u-boot,dm-pre-reloc;
> 




More information about the U-Boot mailing list