[PATCH v3 00/12] Add support for pinmux status command on beaglebone

[Dario Binacchi]

Hi Lokesh,

> Il 09/04/2021 09:21 Lokesh Vutla <lokeshvutla at ti.com> ha scritto:
> 
>  
> Hi Dario,
> 
> On 28/02/21 7:42 pm, Dario Binacchi wrote:
> > 
> > The series was born from the need to check the pinmux setting of a
> > peripheral on a beaglebone board. I then ran the 'pinmux status -a'
> > command but it failed because some operations (get_pin_muxing,
> > get_pin_name and get_pins_count) were missing in the 'pinctrl-single'
> > driver.
> > 
> > The patch series can be cleanly applied to the HEAD of the master which
> > at the time of release points to 08cca188c1
> > ("Merge https://gitlab.denx.de/u-boot/custodians/u-boot-usb") commit
> > 
> > The series was archived with the status 'Changes Requested' because the
> > Sandbox tests failed. I tried them locally and couldn't reproduce. Lokesh
> > Vutla also verified that execution outside of gitlab-ci did not fail. It's
> > been a while since then. I am available to investigate the problem on your
> > indications with changes to the test patch.
> 
> Can you setup azure and check if all the tests are passing? I still see failures
> in gitlab.
> 

Locally I ran sandbox tests (./test/py/test.py --bd sandbox --build) which did not fail. 
Instead, the test for sandbox_flattree failed. As I did for the sandbox configuration, I
added CONFIG_PINCTRL_SINGLE to the sandbox_flattree configuration as well. I'll upload 
version 4 of the series with the fix.

Thanks and regards,
Dario

> Thanks and regards,
> Lokesh
> 
> > 
> > 
> > Changes in v3:
> > - Added Pratyush Yadav review tag.
> > - Updated commit message.
> > - Added Pratyush Yadav review tag.
> > - Added Pratyush Yadav review tag.
> > - Added Simon Glass review tag.
> > - Added Simon Glass review tag.
> > - Added Simon Glass review tag.
> > 
> > Changes in v2:
> > - Added Simon Glass review tag.
> > - Updated commit message.
> > - Added Simon Glass review tag.
> > - Added Pratyush Yadav review tag.
> > - Updated commit message
> > - Split in 2 commits
> > - Check dev_read_addr_size return value.
> > - Updated commit message.
> > - Added Simon Glass review tag.
> > - Updated commit message.
> > - Remove pointer to access functions.
> > - Added Simon Glass review tag.
> > - Added Simon Glass review tag.
> > - Added Simon Glass review tag.
> > - Added error checking when the 'width' property is missing.
> > - Fix coding style.
> > 
> > Dario Binacchi (12):
> >   pinctrl: single: fix format of structure documentation
> >   pinctrl: single: fix the loop counter variable type
> >   pinctrl: single: fix offset management
> >   pinctrl: single: fix debug messages formatting
> >   pinctrl: single: get register area size by device API
> >   pinctrl: single: check "register-width" DT property
> >   pinctrl: single: change function mask default value
> >   pinctrl: single: add register access functions
> >   pinctrl: single: add get_pins_count operation
> >   pinctrl: single: add get_pin_name operation
> >   pinctrl: single: add get_pin_muxing operation
> >   test: pinmux: add test for 'pinctrl-single' driver
> > 
> >  arch/sandbox/dts/test.dts        |  72 +++++
> >  configs/sandbox_defconfig        |   1 +
> >  drivers/pinctrl/pinctrl-single.c | 474 +++++++++++++++++++++++++++----
> >  test/dm/pinmux.c                 |  91 +++++-
> >  4 files changed, 573 insertions(+), 65 deletions(-)
> >