[PATCH 10/13] ARM: dts: synquacer: Add device trees for DeveloperBox

[Tom Rini]

On Wed, Apr 14, 2021 at 10:06:04AM +0900, Masami Hiramatsu wrote:
> Hello Tom,
> 
> Thank you for your comment!
> 
> 2021年4月14日(水) 2:47 Tom Rini <trini at konsulko.com>:
> >
> > On Wed, Apr 14, 2021 at 12:30:15AM +0900, Masami Hiramatsu wrote:
> >
> > > Add device trees for 96boards EE DeveloperBox and basement SynQuacer
> > > SoC dtsi. These files are imported from EDK2 with cosmetic change
> > > and modified for accessing SPI NOR flash.
> > >
> > > Signed-off-by: Masami Hiramatsu <masami.hiramatsu at linaro.org>
> > > ---
> > >  arch/arm/dts/DeveloperBox.dts     |  146 +++++++++
> > >  arch/arm/dts/Makefile             |    2
> > >  arch/arm/dts/SynQuacer.dtsi       |  590 +++++++++++++++++++++++++++++++++++++
> > >  arch/arm/dts/SynQuacerCaches.dtsi |   72 +++++
> >
> > This poses a bit of a naming challenge.  I assume, but please correct me
> > if I'm wrong, that you don't intend to push these dts files to the Linux
> > kernel.  So that means EDK2 is the primary source of the files, yes?
> 
> Yes, those are originally written for the EDK2 and I ported it.

OK.

> > We
> > want to keep them as-is from the upstream project, and note that
> > relevant git hash/tag/etc that matches where we pulled from, to make
> > future syncs easier, in the commit message.
> 
> Let me confirm what you mean, is the git hash/tag/etc what the commit
> I copied from? and note it in commit message or in the devicetree file?

Correct.

> BTW, I made some changes on it for U-Boot drivers.
> - Enabled OP-TEE node by default (EDK2 checks OP-TEE existance
>   and enables it)
> - Add SPI node information for accessing SPI-NOR from U-Boot (EDK2
>  embedded such information inside)
> Thus the DeveloperBox.dts may not be kept as-is.

These kinds of changes can be done in something such as
DeveloperBox-u-boot.dtsi.  Check out the logic in scripts/Makefile.lib
around automatic inclusion of a "-u-boot.dtsi" file.

> > I assume this is not part of the uniphier family, so we should start by
> > naming these as arch/arm/dts/synquacer-... to fit with the general
> > scheme.  Perhaps -developerbox, -core and -caches ?
> 
> OK. BTW, I'm not sure what is the best way to use SYS_CPU and SYS_SOC.
> This SoC family name is SynQuacer and the SoC itself is SC2A11.
> In this case,
> CONFIG_SYS_CPU=synquacer
> CONFIG_SYS_SOC=sc2a11
> or
> CONFIG_SYS_SOC=synquacer-sc2a11

I think the first example you list is likely the best.

> > And for any changes
> > we do need, they go in a -u-boot.dtsi file and then potentially
> > automatically included (if it fits in the logic we have today for that)
> > or specifically #included otherwise.
> 
> It seems that (CONFIG_SYS_SOC)-u-boot.dtsi is automatically included,
> am I correct?

For the full list and how it works, see scripts/Makefile.lib

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210414/7e7b8e1e/attachment.sig>