[PATCH 1/4] command: Use a constant pointer for the help

Simon Glass sjg at chromium.org
Wed Apr 14 21:38:08 CEST 2021


Hi Sean,

On Fri, 9 Apr 2021 at 04:32, Sean Anderson <seanga2 at gmail.com> wrote:
>
> On 4/6/21 12:30 AM, Simon Glass wrote:
> > This text should never change during execution, so it makes sense to
> > use a const char * so that it can be declared as const in the code.
> > Update struct cmd_tbl with a const char * pointer for 'help'.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> >   include/command.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/command.h b/include/command.h
> > index 747f8f80958..675c16a1249 100644
> > --- a/include/command.h
> > +++ b/include/command.h
> > @@ -45,7 +45,7 @@ struct cmd_tbl {
> >                              char *const argv[]);
> >       char            *usage;         /* Usage message        (short) */
>
> Should usage also be const?

I think so, but would need to check it builds, etc.

Regards,
Simon


More information about the U-Boot mailing list