[PATCH] fastboot: Fix overflow when calculating chunk size

Heiko Schocher hs at denx.de
Mon Apr 19 06:31:23 CEST 2021

Hello Sean,

On 16.04.21 23:58, Sean Anderson wrote:
> If a chunk was larger than 4GiB, then chunk_data_sz would overflow and
> blkcnt would not be calculated correctly. Upgrade it to a u64 and cast
> its multiplicands as well. Also fix bytes_written while we're at it.
> Signed-off-by: Sean Anderson <sean.anderson at seco.com>
> ---
>  lib/image-sparse.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Wow chunk size larger than 4G!

But patch seems valid, so

Reviewed-by: Heiko Schocher <hs at denx.de>

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de

More information about the U-Boot mailing list