[PATCH v2] Makefile: fix generating environment file
Rasmus Villemoes
rasmus.villemoes at prevas.dk
Tue Apr 20 21:33:20 CEST 2021
On 20/04/2021 16.43, Oleksandr Suvorov wrote:
> If the CONFIG_USE_DEFAULT_ENV_FILE=y and CONFIG_DEFAULT_ENV_FILE
> points to the empty environment file, the auto-generated file has
> the wrong syntax so it leads to the compilation failure:
>
Glad someone is using CONFIG_USE_DEFAULT_ENV_FILE :) And thanks for
reporting this.
>
> Fix this issue conditionally adding the delimiter ", ".
Hm, yeah, that should work. But I wonder if it would make more sense to
ensure tr always gets a final newline (which then gets translated to a
nul byte, which in turn gives the trailing 0x00). Something like (untested)
define filechk_defaultenv.h
( { grep -v '^#' | grep -v '^$$' ; echo '' ; } | \
tr '\n' '\0' | \
sed -e 's/\\\x0\s*//g' | \
xxd -i ; )
endef
Rasmus
More information about the U-Boot
mailing list