[PATCH 4/5] cmd: allow disabling of timeout for password entry

Steffen Jaeckel jaeckel-floss at eyet-services.de
Wed Apr 21 16:09:46 CEST 2021


On 4/21/21 9:14 AM, Simon Glass wrote:
> On Tue, 13 Apr 2021 at 10:16, Steffen Jaeckel
> <jaeckel-floss at eyet-services.de> wrote:
>>
>> In case a user has to enter a complicated password it is sometimes
>> desireable to give the user more time than the default timeout.
>> Enabling this feature will disable the timeout entirely in case the user
>> presses the <Enter> key before entering any other character.
>>
>> Signed-off-by: Steffen Jaeckel <jaeckel-floss at eyet-services.de>
>> ---
>>
>>  cmd/Kconfig       | 8 ++++++++
>>  common/autoboot.c | 8 +++++++-
>>  2 files changed, 15 insertions(+), 1 deletion(-)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> I wonder if we could have some unit tests for this?


As there are no tests yet for the autoboot part and I don't really feel
comfortable adding one, I guess this has to wait ...


FYI: I've implemented the unit tests & your change requests but I'm
waiting with a re-spin until we've sorted out the open points of Patch 2.


Cheers
Steffen



More information about the U-Boot mailing list