[PATCH 04/17] spi: ich: Don't require the PCH

[Simon Glass]

Hi Bin,

On Thu, 8 Apr 2021 at 14:28, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> On Wed, Apr 7, 2021 at 12:34 PM Simon Glass <sjg at chromium.org> wrote:
> >
> > When booting from coreboot we may not have a PCH driver available. The
> > SPI driver can operate without the PCH but currently complains in this
> > case. Update it to continue to work normally. The only missing feature
> > is memory-mapping of SPI-flash contents, which is not essential.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> >  drivers/spi/ich.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
>
> But I feel this driver is slightly becoming unmaintainable as there
> are many combinations we need to consider ...

Yes it is a bit of a pain. The main one is that in some cases the SPI
bus appears on PCI and in others it is part of the PCH or LPC. This is
a hardware thing though, so I'm not sure what we can do about it.
Perhaps split up the driver?

Regards,
Simon