[PATCH] sunxi: Bring back SD card as MMC device 0

[Andre Przywara]

On Fri, 16 Apr 2021 12:08:09 +0100
Andre Przywara <andre.przywara at arm.com> wrote:

Hi,

> Commit 2243d19e5618 ("mmc: mmc-uclass: Use dev_seq() to read aliases
> node's index") now actually enforces U-Boot's device enumeration policy,
> where explicitly named devices come first, then any other non-named
> devices follow, without filling gaps.
> 
> For quite a while we have had an "mmc1 = &mmc2;" alias in our
> sunxi-u-boot.dtsi, which now leads to the problem that the SD card
> (which was always mmc device 0) now gets to be number 2.
> I guess this breaks quite some boot scripts, and is confusing at least.
> 
> Just add an explicit mmc0 alias in the very same file to fix this and
> restore the old behaviour.

Can someone please say if this is the right solution?
I think the SD card has always been mmc device 0 in U-Boot, so I think
it's worth keeping that. Just not sure if this is the right way of
fixing that?

Cheers,
Andre

> 
> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> Reported-by: Samuel Holland <samuel at sholland.org>
> ---
>  arch/arm/dts/sunxi-u-boot.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/dts/sunxi-u-boot.dtsi b/arch/arm/dts/sunxi-u-boot.dtsi
> index a4227a3c22d..06da009fa28 100644
> --- a/arch/arm/dts/sunxi-u-boot.dtsi
> +++ b/arch/arm/dts/sunxi-u-boot.dtsi
> @@ -12,6 +12,7 @@
>  
>  / {
>  	aliases {
> +		mmc0 = &mmc0;
>  		mmc1 = &mmc2;
>  	};
>