[PATCH v2 07/13] mmc: synquacer: Add SynQuacer F_SDH30 SDHCI driver

[Jaehoon Chung]

On 4/26/21 7:05 AM, Jassi Brar wrote:
> On Mon, 19 Apr 2021 at 17:05, Jaehoon Chung <jh80.chung at samsung.com> wrote:
> 
>>> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c
>>> index d9ab6a0a83..f038debc6c 100644
>>> --- a/drivers/mmc/sdhci.c
>>> +++ b/drivers/mmc/sdhci.c
>>> @@ -708,6 +708,15 @@ static int sdhci_init(struct mmc *mmc)
>>>
>>>       sdhci_set_power(host, fls(mmc->cfg->voltages) - 1);
>>>
>>> +     if (IS_ENABLED(CONFIG_F_SDH30_SDHCI)) {
>>
>> I don't want to add specific sdhci driver configuration in sdhci.c.
>>
>> According to below comment and Specification,
>> it has to delay 1ms. Can it be removed the above condition checking?
>>
>>> +             /*
>>> +              * Reference to Part1 Physical Layer Simplified Specification
>>> +              * Ver 3.01, 6.4.1 Power Up
>>> +              * This delay must be at least 74 clock sizes, or 1 ms.
>>> +              */
>>> +             udelay(1000);
>>
>> I don't have any objection about this, If possible, it needs to calculate clock-cycle with real clock value in future.
>>
> This change is carried over from some ancient patchset.
> While it might be helpful to some platform, I tried removing the
> delay, and it still works. So for f_sdh30 we don't seem to need it.

Thanks for checking it. 

Best Regards,
Jaehoon Chung

> 
> thanks.
>