[PATCH] sunxi: Select environment MMC based on boot device

[Maxime Ripard]

Hi,

On Mon, Apr 19, 2021 at 04:35:04PM +0100, Andre Przywara wrote:
> On Sun, 18 Apr 2021 22:16:21 -0500
> Samuel Holland <samuel at sholland.org> wrote:
> 
> (CC:ing Maxime)
> 
> Hi,
> 
> > Currently, the environment is always stored in eMMC if eMMC is enabled
> > in the config. This means images written to SD and eMMC will cross-
> > contaminate their environments unless the configuration is changed.
> > 
> > By dropping the device number from the environment location string and
> > implementing mmc_get_env_dev, we will always use the environment from
> > the boot device when booting from SD/eMMC.
> 
> Yeah, indeed, thanks for sending this. I will have a closer look and
> test tonight.
> 
> AFAIR Maxime had reservations towards this approach in the past, he
> mentioned that this fixed environment location had a use case?
> 
> Maxime, can you comment whether this is still needed? I think being
> able to just "dd" (or "mmc write" in U-Boot) the very same image to an
> eMMC is a very compelling use case, to install firmware from a bootable 
> SD card. I have patches to a similar effect, including loading the env
> from SPI when booting from SPI, and a U-Boot menu to make this user
> friendly, so would like to know whether we can push this forward.

I don't recall, really, and it's really a matter of policy. If you want
to change it please go ahead, you're in charge now ;)

The only thing that would be great to keep as is would be fastboot (or
at least until we have some way to select which device we want to
flash).

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210426/7773ec06/attachment.sig>